Move shared JavaScript to lib folder #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
b835956 to
7dc024e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
7dc024e to
98e67e7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
98e67e7 to
ab960f3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
ab960f3 to
65d4b62
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
65d4b62 to
29c135d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
5f7d6f9 to
f9c61d7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
f9c61d7 to
3f87634
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
3f87634 to
99cd145
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
99cd145 to
7662dab
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
joelanman
reviewed
Jul 27, 2022
joelanman
reviewed
Jul 27, 2022
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
7662dab to
7da97d3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--5h2aj9
|
I think the test can be fixed by replacing: with |
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
7da97d3 to
0a17593
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
ffe15f6 to
e0ff427
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
7b7f1e9 to
364bfae
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
364bfae to
ca3f699
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
As this PR is already pretty big I've put the layout template includes changes in a separate PR, #1499. |
Also rename application.js to kit.js to avoid clashes. Co-authored-by: Joe Lanman <joe.lanman@digital.cabinet-office.gov.uk>
Co-authored-by: NoraGDS <57447099+NoraGDS@users.noreply.github.com>
We want to make sure that any shared JS files we create can't have name collisions with files the user wants to create. Putting the files in a separate namespaced folder mitigates against this.
The update script tests run create-release-archive a lot, which involves a lot of shelling out, and on Windows this is very slow, so we increase the test timeout again to account for this. Ideally there would be less shelling out, but that's a problem for another day.
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
c07ecb9 to
5e5e10b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
5e5e10b to
f88485e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
We want to make sure that on Windows we can compare files regardless of what line endings the users files have, and that any changes we make have the same line endings.
Simplify the update shell script by combining the Node.js post scripts into one mega script. We also move the final message from update script to very end.
lfdebrux
force-pushed
the
ldeb-move-js-to-lib
branch
from
f88485e to
5e94bc7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-move--gmtxvp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, a user would just add their javascript to
app/assets/javascripts/application.jsand not have to see or worry about things like intitialsing govuk-frontend, or the auto-store data JS. This would make updating a user's prototype easier and less risky, because currently it is possible they have changed the standard files. It will also mean less is needed to bootstrap a prototype using a package.This PR moves the standard JS to the lib folder as
lib/assets/javascripts/kit.js, and replacesapp/assets/javascripts/application.jswith a simple placeholder that a user can rewrite completely as desired.Note that we make sure that all pages include both scripts by adding
kit.jstoapp/views/includes/scripts.html. This PR doesn't help users update that file, but ideally in another PR we would make it so that updating to v13 also takes care of this.Resolves #1387.